Skip to content

Conversation

@tokoko
Copy link
Contributor

@tokoko tokoko commented Jun 5, 2025

Adds basic support for turning sql strings into substrait plans.
Covers most common sql operators, but function support is minimal.

Copy link
Member

@EpsilonPrime EpsilonPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One future improvement might be to use the dialect to handle conversion from the local name into Substrait. That could get the right implementation and/or option converted without needing to assume that the name matches somewhere. Obviously that would need a dialect file for each engine which we don't have yet.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since there is now a growing number of dependencies used in tests, I think we need to pin dependencies to specific versions to ensure repeatable test runs both locally and in ci. I plan to switch gh actions to use uv for tests in a follow-up PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed the conflict

@tokoko
Copy link
Contributor Author

tokoko commented Jun 13, 2025

For now we'll probably have to start with some sort of base dialect class that can be extended by dialect implementations to better make sense of what will actually be required from the eventual dialect files. function name mapping is an obvious one of course, but I feel like there might be other requirements.

@EpsilonPrime EpsilonPrime merged commit 1d9fbda into substrait-io:main Jun 13, 2025
18 checks passed
@tokoko tokoko deleted the sql branch June 13, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants